Add static ipam to kernel parameters for ISO patching: #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds static IPAM to kernel parameters when patching an ISO. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
changed the title
CLI Flag to enable/disable ISO static IPAM. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
===================================
Coverage 50% 50%
===================================
Files 27 27
Lines 2976 3042 +66
===================================
+ Hits 1493 1550 +57
- Misses 1428 1435 +7
- Partials 55 57 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
These are needed for proper VLAN interface creation. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This moves the gating to the constructing of the kernel parameters and makes it explicit to whether ipam is included or not. Signed-off-by: Jacob Weinstock <[email protected]>
Search domains was missing from being parsed. Some basic tests were added. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
iso-static-ipam
branch
from
183d3f4
to
c4fa09d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds optional static IPAM data to kernel parameters when patching an ISO.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: